Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More fine tuning #614

Merged
merged 46 commits into from
Oct 14, 2024
Merged

More fine tuning #614

merged 46 commits into from
Oct 14, 2024

Conversation

c8y3
Copy link
Contributor

@c8y3 c8y3 commented Oct 11, 2024

  • endpoint GET /api/v2/cases, changed field cases into data, so that endpoints which return paginated lists are standardized
  • endpoint GET /api/v2/cases/{identifier}/iocs, changed field iocs into data, so that endpoints which return paginated lists are standardized
  • return 404 when trying to delete inexistant task
  • return 404 when trying to delete inexistant IOC
  • return 404 when trying to delete inexistant asset
  • return 404 when trying to create an asset in an inexistant case
  • moved code out of utils.py into the blueprints namespace (in access_controls.py and responses.py)
  • some cleanups: removed some seemingly dead methods, marked some methods as private (underscore prefix), simple quotes vs. double quotes

c8y3 added 30 commits October 9, 2024 08:30
@c8y3
[IMP] For endpoint GET /api/v2/cases, changed field cases into data
7207df8
@c8y3
[IMP] For endpoint GET /api/v2/cases/{identifier}/iocs, changed field…
dd7ebe8 
… iocs into data
@c8y3
[IMP] Uniform syntax FROM and AS
88f5ed0
@c8y3
[IMP] Change user customer to initial so that the customer can be rem…
1aa8bbd 
…oved
@c8y3
[IMP] Remove customers only in tests_rest_customers
6fe85fa
@c8y3
[IMP] Remove users after each test
38183aa
@c8y3
[IMP] Removed spurious line
2f7ef1f
@c8y3
[IMP] Return 404 when trying to delete inexistant IOC
2904d9b
@c8y3
[IMP] Simple quotes instead of double quotes
ccbc43b
@c8y3
[IMP] Return 404 when trying to delete inexistant task
afb054d
@c8y3
[IMP] Missing line break
8541fd4
@c8y3
[IMP] Renamed method to follow coding conventions
f9487c2
@c8y3
[IMP] Introduced method in business layer
d747c8d
@c8y3
[IMP] Return 404 when deleting inexistant asset of creating an asset …
0c40079 
…on an inexistant case
@c8y3
[IMP] Moved ac_api_return_access_denied into namespace blueprints
91e6088
@c8y3
[IMP] Moved ac_api_requires_client_access into namespace blueprints
e756d25
@c8y3
[IMP] Moved is_user_authenticated into namespace blueprints
c53f071
@c8y3
[IMP] Removed seemingly dead method is_authentication_local
44f275a
@c8y3
[IMP] Moved code out of util.py into blueprints namespace
70a5afd
@c8y3
[IMP] Moved update_current_case out of util.py into blueprints namespace
fbe2f1f
@c8y3
[IMP] Made update_current_case private
1f302b0
@c8y3
[IMP] Moved log_exception_and_error out of util.py into blueprints na…
7415700 
…mespace
@c8y3
[IMP] Moved page_not_found out of util.py into blueprints namespace
b3f561b
@c8y3
[IMP] Moved endpoint_removed out of util.py into blueprints namespace
73dc62c
@c8y3
[IMP] Moved response_error out of util.py into blueprints namespace
6c3ac34
@c8y3
[IMP] Moved response_success out of util.py into blueprints namespace
6d1eccd
@c8y3
[FIX] Path of moved imports
3e9627b
@c8y3
[IMP] Moved response into namespace blueprints
12204dc
@c8y3
[IMP] Removed seemingly dead code
68e0e85
@c8y3
[IMP] Moved method is_authentication_oidc into namespace blueprints
38734b6
@c8y3 c8y3 added the quality label Oct 11, 2024
@c8y3 c8y3 requested a review from whikernel October 11, 2024 06:15
@whikernel whikernel merged commit 8ca28ba into develop Oct 14, 2024
6 checks passed
@c8y3 c8y3 deleted the api_v2_get_cases branch October 15, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whikernel whikernel whikernel approved these changes

Assignees
No one assigned
Labels
quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c8y3 @whikernel